Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.

debugger: assign Environment to DebugContext too#7519

Closed
indutny wants to merge 1 commit intonodejs:masterfrom
indutny:fix/gh-7517
Closed

debugger: assign Environment to DebugContext too#7519
indutny wants to merge 1 commit intonodejs:masterfrom
indutny:fix/gh-7517

Conversation

@indutny
Copy link
Copy Markdown
Member

@indutny indutny commented Apr 27, 2014

fix #7517

@Nodejs-Jenkins
Copy link
Copy Markdown

Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion.

The following commiters were not found in the CLA:

  • Fedor Indutny

You can fix all these things without opening another issue.

Please see CONTRIBUTING.md for more information

@tjfontaine
Copy link
Copy Markdown

lgtm

@tjfontaine
Copy link
Copy Markdown

actually -- can I get a test case? shouldn't be too awful to do

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

env->isolate()?

@indutny
Copy link
Copy Markdown
Member Author

indutny commented May 2, 2014

Thanks, landed in 8398bf9

@indutny indutny closed this May 2, 2014
@indutny indutny deleted the fix/gh-7517 branch May 2, 2014 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants