Skip to content

fix device client and add test #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2016
Merged

fix device client and add test #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/main/java/cn/jpush/api/device/DeviceClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,6 @@ public DefaultResult updateDeviceTagAlias(String registrationId, String alias,

public DefaultResult bindMobile(String registrationId, String mobile)
throws APIConnectionException, APIRequestException {
Preconditions.checkNotNull(mobile, "The mobile must not be null.");

if ( StringUtils.isEmpty(mobile) ) {
// delete bind while mobile is empty.
mobile = "";
Expand Down
15 changes: 15 additions & 0 deletions src/test/java/cn/jpush/api/device/DeviceNormalRemoteTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,4 +181,19 @@ public void testBindMobile() throws APIConnectionException, APIRequestException
DefaultResult result = jpushClient.bindMobile(REGISTRATION_ID1, "13000000000");
assertTrue(result.isResultOK());
}

@Test
@TestOrder(order = 361)
public void testBindMobile_null() throws APIConnectionException, APIRequestException {
DefaultResult result = jpushClient.bindMobile(REGISTRATION_ID1, null);
assertTrue(result.isResultOK());
}

@Test
@TestOrder(order = 362)
public void testBindMobile_empty() throws APIConnectionException, APIRequestException {
DefaultResult result = jpushClient.bindMobile(REGISTRATION_ID1, "");
assertTrue(result.isResultOK());
}

}