Skip to content

Conversation

@agcolom
Copy link
Member

@agcolom agcolom commented Mar 2, 2014

No description provided.

@jaspermdegroot
Copy link
Member

👍

@jaspermdegroot
Copy link
Member

@agcolom

Can you add a component to the commit message? I have to admit that I don't really know what we should use for this. For the 1.4.1 update it was "mobile version" (78b25fc). Or maybe we should use "All" for this.

@agcolom
Copy link
Member Author

agcolom commented Mar 3, 2014

@uGoMobi Hi Jasper, Yes, I can do that. I've just checked what UI does (https://github.com/jquery/api.jqueryui.com) and their message was Upgrade to jQuery UI 1.10.4 so I thought that was ok (I'd have to use Upgrade instead of upgrade). Should I check with @scottgonzalez ?

@jaspermdegroot
Copy link
Member

@agcolom

I understand. I thought we should always start with a component, no matter what kind of change. Maybe exceptions are allowed in repos for which we don't generate a changelog anyway. Yes, let's ask @scottgonzalez.

@agcolom
Copy link
Member Author

agcolom commented Mar 3, 2014

@uGoMobi Yes I agree with you and I like Mobile Version as component name in this case. I thought I'd check what UI was using and was rather surprised to see there wasn't a component name in this case.

@agcolom agcolom closed this in 8cfd4ce Mar 3, 2014
@agcolom agcolom deleted the update-to-1.4.2 branch March 3, 2014 18:19
apsdehal pushed a commit that referenced this pull request Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants