updated to jQuery Mobile 1.4.2 #281

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@agcolom
Member

agcolom commented Mar 2, 2014

No description provided.

@jaspermdegroot

This comment has been minimized.

Show comment Hide comment
@jaspermdegroot

jaspermdegroot Mar 2, 2014

Member

👍

Member

jaspermdegroot commented Mar 2, 2014

👍

@jaspermdegroot

This comment has been minimized.

Show comment Hide comment
@jaspermdegroot

jaspermdegroot Mar 2, 2014

Member

@agcolom

Can you add a component to the commit message? I have to admit that I don't really know what we should use for this. For the 1.4.1 update it was "mobile version" (78b25fc). Or maybe we should use "All" for this.

Member

jaspermdegroot commented Mar 2, 2014

@agcolom

Can you add a component to the commit message? I have to admit that I don't really know what we should use for this. For the 1.4.1 update it was "mobile version" (78b25fc). Or maybe we should use "All" for this.

@agcolom

This comment has been minimized.

Show comment Hide comment
@agcolom

agcolom Mar 3, 2014

Member

@ugomobi Hi Jasper, Yes, I can do that. I've just checked what UI does (https://github.com/jquery/api.jqueryui.com) and their message was Upgrade to jQuery UI 1.10.4 so I thought that was ok (I'd have to use Upgrade instead of upgrade). Should I check with @scottgonzalez ?

Member

agcolom commented Mar 3, 2014

@ugomobi Hi Jasper, Yes, I can do that. I've just checked what UI does (https://github.com/jquery/api.jqueryui.com) and their message was Upgrade to jQuery UI 1.10.4 so I thought that was ok (I'd have to use Upgrade instead of upgrade). Should I check with @scottgonzalez ?

@jaspermdegroot

This comment has been minimized.

Show comment Hide comment
@jaspermdegroot

jaspermdegroot Mar 3, 2014

Member

@agcolom

I understand. I thought we should always start with a component, no matter what kind of change. Maybe exceptions are allowed in repos for which we don't generate a changelog anyway. Yes, let's ask @scottgonzalez.

Member

jaspermdegroot commented Mar 3, 2014

@agcolom

I understand. I thought we should always start with a component, no matter what kind of change. Maybe exceptions are allowed in repos for which we don't generate a changelog anyway. Yes, let's ask @scottgonzalez.

@agcolom

This comment has been minimized.

Show comment Hide comment
@agcolom

agcolom Mar 3, 2014

Member

@ugomobi Yes I agree with you and I like Mobile Version as component name in this case. I thought I'd check what UI was using and was rather surprised to see there wasn't a component name in this case.

Member

agcolom commented Mar 3, 2014

@ugomobi Yes I agree with you and I like Mobile Version as component name in this case. I thought I'd check what UI was using and was rather surprised to see there wasn't a component name in this case.

@agcolom agcolom closed this in 8cfd4ce Mar 3, 2014

@agcolom agcolom deleted the agcolom:update-to-1.4.2 branch Mar 3, 2014

apsdehal added a commit that referenced this pull request Feb 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment