Skip to content

Conversation

dmethvin
Copy link
Member

@mgol Does this look ok to you?

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @mgol, @markelog and @gibson042 to be potential reviewers

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.255% when pulling 09813a0 on dmethvin:only3 into 2cf01c5 on jquery:master.

<meta charset="utf-8">
<title>jQuery Migrate Test Suite</title>
<!-- Ensure IE doesn't fall back into oldIE modes -->
<meta http-equiv="X-UA-Compatible" content="IE=Edge" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this? we still test on IE9-11 so it seems it's better to leave it there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In IE8 there used to be a button next to the URL to switch into IE7 Compatibility View, which people accidentally pressed. I thought they removed it in IE9, but I just checked and it didn't go away until IE10. Since IE10 the only way for any IE10+ browser to be forced into Compat View by the user is to either manually add it in a deeply buried dialog or use Enterprise Mode and have their IT department list it in a config file. That's super unlikely in our unit test scenario.

Bottom line is that you're right, since it is possible to push that button in IE9 I'll restore it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the button only went away in IE 11, not 10.

@dmethvin dmethvin closed this in e1b5396 Mar 25, 2016
@dmethvin dmethvin deleted the only3 branch April 28, 2016 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants