Skip to content

Build: Only support jQuery 3.0 and master #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Build: Only support jQuery 3.0 and master #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions Gruntfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,10 @@ module.exports = function( grunt ) {
],
tests: {
"jquery": [
"dev+2.x-git",
"min+2.x-git.min",
"dev+2.2.2",
"dev+1.x-git",
"dev+1.12.2"
"dev+git",
"min+git.min",
"dev+3.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work only after the final 3.0.0 release, won't it? We should probably put 3.0.0-beta for now. Or wait with this entry for a final release and for now just do the git part.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, since I didn't care about the beta I figured that testing with git was good enough for now and I was just getting a running start on the release. 😺

"dev+3.0.0.min"
]
},
banners: {
Expand Down
8 changes: 3 additions & 5 deletions test/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
<head>
<meta charset="utf-8">
<title>jQuery Migrate Test Suite</title>
<!-- Ensure IE doesn't fall back into oldIE modes -->
<meta http-equiv="X-UA-Compatible" content="IE=Edge" />

<!-- QUnit -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this? we still test on IE9-11 so it seems it's better to leave it there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In IE8 there used to be a button next to the URL to switch into IE7 Compatibility View, which people accidentally pressed. I thought they removed it in IE9, but I just checked and it didn't go away until IE10. Since IE10 the only way for any IE10+ browser to be forced into Compat View by the user is to either manually add it in a deeply buried dialog or use Enterprise Mode and have their IT department list it in a config file. That's super unlikely in our unit test scenario.

Bottom line is that you're right, since it is possible to push that button in IE9 I'll restore it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the button only went away in IE 11, not 10.

<link rel="stylesheet" href="../external/qunit/qunit.css" media="screen">
Expand All @@ -17,14 +15,14 @@
TestManager.init({
"jquery": {
urlTag: "jquery",
choices: "dev,min,git,2.2.1,2.1.4,2.0.3,1.12.1,1.11.3,1.10.2,1.9.1,1.8.3,1.7.2,1.6.4"
choices: "dev,min,git,3.0.0"
},
"jquery-migrate": {
urlTag: "plugin",
choices: "dev,min,git,1.0.0,1.1.1,1.2.1"
choices: "dev,min,git,3.0.0"
}
});
TestManager.loadProject( "jquery", "2.x-git" );
TestManager.loadProject( "jquery", "git" );
// Close this script tag so file will load
</script>
<script>
Expand Down