This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Panel: Transition with new toolbars#8397
Closed
cgack wants to merge 2 commits intojquery-archive:1.5-devfrom
Closed
Panel: Transition with new toolbars#8397cgack wants to merge 2 commits intojquery-archive:1.5-devfrom
cgack wants to merge 2 commits intojquery-archive:1.5-devfrom
Conversation
Contributor
Author
|
@arschmitz this is ready for a round of review |
js/widgets/panel.js
Outdated
| this._page().children( ".ui-header:not(.ui-header-fixed), " + | ||
| ".ui-content:not(.ui-popup), .ui-footer:not(.ui-footer-fixed)" ) ); | ||
| this._page().children( ".ui-toolbar-header:not(.ui-toolbar-header-fixed), " + | ||
| "[data-role='toolbar']," + |
Contributor
There was a problem hiding this comment.
need to add in $.ui.ns here for now to support chaning that until its removed in 1.6 and will be data-ui-toolbar
add mobile namespace Fixes jquery-archivegh-8324
Contributor
Author
|
@arschmitz ready for another round of review on this fix |
Contributor
|
landed in 1.5-dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-8324