This is a pull request for bug #7639 to be merged into the 1.8 branch #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t editable. Fixed #7639 - merge into 1.8 branch
Member
|
Thanks, but this pulls in either too much or not enough. As of 5095871, master supports contenteditable, but 1-8-stable does not. While these specific tests will pass on contenteditable because we only check that the menu is triggered, not that values are properly used, they don't belong in 1-8-stable if there's no real contenteditable support. If you remove everything related to contenteditable, we can land this. |
… it's not yet supported. Bug #7639.
Author
|
I've removed the contenteditable stuff. |
Member
|
Thanks, landed in 9668cb8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry picking of 06f6fa8 into the 1.8 branch - this would be useful as it would mean I could stop using a custom version of jQuery UI for my project.