New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IE layout bug from support tests. #12869 #1025

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@scottgonzalez
Copy link
Member

scottgonzalez commented Nov 8, 2012

No description provided.

@mikesherov

This comment has been minimized.

Copy link
Member

mikesherov commented Nov 11, 2012

@scottgonzalez, do a blame on the file and see why the old line was present. I believe this was me fixing a bug in actual IE6.

@scottgonzalez

This comment has been minimized.

Copy link
Member

scottgonzalez commented Nov 12, 2012

Ok, I'll test against the fiddle from #11048.

Set zoom on the body after running support tests to avoid layout chan…
…ges in IE8/9/10 running in IE 7 mode. Fixes #12869.
@scottgonzalez

This comment has been minimized.

Copy link
Member

scottgonzalez commented Nov 15, 2012

@mikesherov I tested against the previous bug, and this doesn't cause a regression.

In jQuery 1.7.1 (prior to the fix for #11048), the positioned element shifted down several pixels. If you run the same test against 1.7.2 with the zoom removed, the element is shifted down a few pixels (improved, but not fixed). Setting the zoom on either the container or the body prevents the element from shifting down.

I've added another comment to the line I changed to reference the old ticket as well, so that it's clear what this line is doing.

@dmethvin

This comment has been minimized.

Copy link

dmethvin commented on src/support.js in b586ced Nov 16, 2012

I was concerned this might reset a zoom the user selected from a previous visit, but the user's zoom setting (from IE's menu or control-wheel on the mouse) does not seem to affect body.style.zoom.

@philwareham

This comment has been minimized.

Copy link

philwareham commented Dec 19, 2012

Using jQuery 1.9beta1 I'm seeing the style="zoom: 1; " showing up on the <body> tag in webkit browsers. Possibly a bug related to this commit?

@scottgonzalez

This comment has been minimized.

Copy link
Member

scottgonzalez commented Dec 19, 2012

@philwareham Is that causing issues for you or do you just not like the style being there?

@philwareham

This comment has been minimized.

Copy link

philwareham commented Dec 19, 2012

Well, for one thing zoom is not a valid CSS rule, it's an IE proprietary rule that even they have deprecated at IE9 so it should never be visible to modern browsers.

It's creating loads of CSS error warnings in the console on Opera.

Basically, if you are going to use it, make sure it's only applied to IE < 9 and nothing else.

mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment