Skip to content

Fix IE layout bug from support tests. #12869 #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

scottgonzalez
Copy link
Member

No description provided.

@mikesherov
Copy link
Member

@scottgonzalez, do a blame on the file and see why the old line was present. I believe this was me fixing a bug in actual IE6.

@scottgonzalez
Copy link
Member Author

Ok, I'll test against the fiddle from #11048.

…ges in IE8/9/10 running in IE 7 mode. Fixes #12869.
@scottgonzalez
Copy link
Member Author

@mikesherov I tested against the previous bug, and this doesn't cause a regression.

In jQuery 1.7.1 (prior to the fix for #11048), the positioned element shifted down several pixels. If you run the same test against 1.7.2 with the zoom removed, the element is shifted down a few pixels (improved, but not fixed). Setting the zoom on either the container or the body prevents the element from shifting down.

I've added another comment to the line I changed to reference the old ticket as well, so that it's clear what this line is doing.

@philwareham
Copy link

Using jQuery 1.9beta1 I'm seeing the style="zoom: 1; " showing up on the <body> tag in webkit browsers. Possibly a bug related to this commit?

@scottgonzalez
Copy link
Member Author

@philwareham Is that causing issues for you or do you just not like the style being there?

@philwareham
Copy link

Well, for one thing zoom is not a valid CSS rule, it's an IE proprietary rule that even they have deprecated at IE9 so it should never be visible to modern browsers.

It's creating loads of CSS error warnings in the console on Opera.

Basically, if you are going to use it, make sure it's only applied to IE < 9 and nothing else.

mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants