Skip to content

Conversation

markelog
Copy link
Member

In most cases end tags are unnecessary and their absence make jQuery.buildFragment even more consistent across browsers, when jQuery.clean takes incorrect HTML argument as a string.

For example – in this pull, specifically in this line, jQuery#html takes as argument incorrect HTML-string, in new browsers, area element will be created, but in oldIE, you will have only map element, btw, oldIE always return coords value, even if it is not defined.

Incorrect HTML-strings should not be passed to jQuery methods, but it's nice when jQuery can process them more consistently across browsers and it will shave off couple of bytes.

@rwaldron
Copy link
Member

Ticket? Why are you removing a test?

@markelog
Copy link
Member Author

Ticket?

I have one, i created it after i pulled, so i can link ticket to the pull

Why are you removing a test?

Checkout pull description

@rwaldron
Copy link
Member

I have one, i created it after i pulled, so i can link ticket to the pull

Yes, I saw that. Generally, a ticket comes first, where the issue itself can be discussed.

@gnarf
Copy link
Member

gnarf commented Nov 26, 2012

The test passes after a re-test btw... Wish there was some way we could get the "recount" to update status on jenkins/mergeatron.

@mikesherov
Copy link
Member

@gnarf37 file an issue :). We'll be improving mergeatron based on jQuery's usage.

@mikesherov
Copy link
Member

@jquerybot retest

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this change? It breaks the leading-text case: http://jsfiddle.net/NzCTZ/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gibson042 thanks, i missed that :-(, i added test for this case

@gibson042
Copy link
Member

It's interesting that this seems to have such broad support (though I would like to confirm on some mobile platforms), but if the closing tags are truly unnecessary for our purposes then I'm fine with dropping them.

@markelog
Copy link
Member Author

I would like to confirm on some mobile platforms

Would you do it? Or you asking me to do it?

@gibson042
Copy link
Member

I'll throw some BrowserStack VMs at it, and recommend that you test it too if you can. @toddparker, @uGoMobi, @scottjehl: is there a better way?

@gibson042
Copy link
Member

Well, I didn't see any failures introduced by this change. Unless the peanut gallery find a problem, I think it's all good.

@markelog
Copy link
Member Author

recommend that you test it too if you can

@gibson042 Right know i don't have many emulators, although i checked in some of them.

@rwaldron
Copy link
Member

Tested in BrowserStack VMs as well, LGTM 👍

@rwaldron
Copy link
Member

I'm still getting a "Merge With Caution" message on the PR (but seems irrelevant because merges just fine)

@mikesherov
Copy link
Member

@rwldrn, please ignore the caution for now.

@rwaldron
Copy link
Member

ignoring

@dmethvin
Copy link
Member

...how can I let them know that as a result of the unfreezing process, I have no inner monologue?

@dmethvin dmethvin closed this in 9ae6b1a Nov 28, 2012
@dmethvin
Copy link
Member

I couldn't believe this actually seems to work!

mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants