Skip to content

Fix #11115: remove boolHook (where feasible) #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

gibson042
Copy link
Member

This one is much less clear-cut than #12600, upon which it depends. It's just a matter of picking inconsistencies: because IE<8 is incapable of differentiating the relevant properties and attributes, the oldest of the oldIEs must necessarily get left behind in order to correctly draw a distinction between boolean them.

If we accept this, it means that modern browsers and IE8+ will correctly interpret selectors referencing boolean attributes from jQuery 1.9 on, and most of this code will be removed in jQuery 2.0.

If we don't, we either commit to incorrectly interpreting those selectors indefinitely or we introduce this as a documented inconsistency between 1.9 and 2.0.

IOW: ROCKjQueryHARD PLACE

Sizes - compared to 12600 @ f9e0e510cb01daab6348e849fbec6836060190d4

    263891      (+216)  dist/jquery.js                                         
     92218       (+74)  dist/jquery.min.js                                     
     32588       (+24)  dist/jquery.min.js.gz

@dmethvin
Copy link
Member

Per @timmywil's idea, waiting for a rewrite using .default* properties. You can either tack on this pull or create a new one.

@dmethvin
Copy link
Member

Looking pretty good so far, what are your remaining concerns?

@gibson042
Copy link
Member Author

No more concerns; just a bit of work to get it functioning the same on IE<8, IE8, and everything else. I suppose it could land now if we need it to.

@dmethvin
Copy link
Member

Okay, I may be back later tonight and can look at it then depending on how much eggnog I have nogged.

@gibson042 gibson042 closed this in a763ae7 Dec 16, 2012
mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants