Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
#11317: jQuery.ifNumeric #684
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
I'm not a fan of adding another utility-ish function that people can bikeshed. We're already getting that with isNumeric itself, like people who want floating-point numbers to be excluded.
The two changes in
There is no discussion, no documentation and it appears to increase the API surface area for very little benefit. The API
Regarding byte count: reverting the css.js work takes this change from -3 to +9. But I would exempt that from "cheating" because it is related code and would not have been analyzed otherwise. Also, I did say that the method came along with a reduction, not that it was solely responsible for one. ;)
Regarding the API: I'm not married to the name, although the best one is already taken.