#11317: jQuery.ifNumeric

[gibson042]

jQuery Size - compared to last make
  250296   (+112) jquery.js
   94242    (+24) jquery.min.js
   33451     (-3) jquery.min.js.gz

[dmethvin]

I'm not a fan of adding another utility-ish function that people can bikeshed. We're already getting that with isNumeric itself, like people who want floating-point numbers to be excluded.

The two changes in .css() can be done independently, so I think you are cheating on the byte count! :)

Other opinions?

[rwaldron]

Did you read the complete discussion here: http://bugs.jquery.com/ticket/6652 or the original patch #416? The check for an empty string is very much intentional. PLEASE read tickets that are cited before making changes like this.

cc @gnarf37

[gibson042]

As a matter of fact, I did read http://bugs.jquery.com/ticket/6652. And I also read the source for jQuery.trim, which always returns a string. The equality check may be intentional, but it is not necessary.

[rwaldron]

-1

There is no discussion, no documentation and it appears to increase the API surface area for very little benefit. The API ifNumeric itself if awkward, intuitively, I would want that to accept an expression to be evaluated and a callback, but I'd be way wrong.

[gibson042]

Regarding byte count: reverting the css.js work takes this change from -3 to +9. But I would exempt that from "cheating" because it is related code and would not have been analyzed otherwise. Also, I did say that the method came along with a reduction, not that it was solely responsible for one. ;)

Regarding the API: I'm not married to the name, although the best one is already taken.

[timmywil]

This ticket has been closed: plugin.