fixes #12282, sometimes IE10 and lower have document.readyState == "interactive" way too early #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interactive" way too early
| // IE10 and lower don't handle "interactive" properly... use a weak inference to detect it | ||
| // hey, at least it's not a UA sniff | ||
| // discovered by ChrisS here: http://bugs.jquery.com/ticket/12282#comment:15 | ||
| if ( document.attachEvent ? document.readyState === "complete" : document.readyState !== "loading" ) { |
There was a problem hiding this comment.
currently no good way I can see to detect that IE9 and IE10 have fired interactive too early. Although, now that there's this repeatable test case, perhaps you can poke around too. For now, this seems to be the only way (although I agree it's dirty).
|
Thanks mike! I was getting gray hairs by this one... |
|
@peterschmidler Thanks. Keeping my fingers crossed that nothing pops up in chrome or Firefox! |
|
This fix was just what I needed after upgrading to 1.8.0. Looking forward to seeing it in a stable jQuery release (and NuGet package, in my case). Thanks, Mike! |
mescoda
pushed a commit
to mescoda/jquery
that referenced
this pull request
Nov 4, 2014
nvenegas
pushed a commit
to skatejs/skatejs
that referenced
this pull request
Jun 19, 2015
ihilt
added a commit
to ihilt/youmightnotneedjquery
that referenced
this pull request
May 18, 2017
Change readyState example to handle IE9+ weirdness. See pull request: jquery/jquery#901
This was referenced May 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With tests! Conclusive, repeatable proof!