-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
abdullah.js.org #10328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
abdullah.js.org #10328
Conversation
MattIPv4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there,
❌ This PR appears to be adding or modifying files other than the cnames_active.js file, which you shouldn't be doing.
To request a subdomain from js.org, your pull request should add a single new line to cnames_active.js that represents the subdomain you wish to request, and the target for the CNAME DNS record. There should be no other files in your PR diff.
MattIPv4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there!
❌ The site you have linked to for your js.org domain request returns a 404: https://abdullahmethod.github.io/
Please fix this before we can process your js.org domain request. 🛠
| var cnames_active = { | ||
| "": "js-org.github.io", | ||
| "abdullah": "abdullahmethod.github.io", | ||
| "toolkit": "tools-kit-pro.netlify.app", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please only add a single subdomain entry in a pull request. If you wish to request additional subdomains, please open additional pull requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still need to remove this file
|
|
||
| var cnames_active = { | ||
| "": "js-org.github.io", | ||
| "abdullah": "abdullahmethod.github.io", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your requested js.org subdomain must be inserted in alphabetical order in the cnames_active.js file before we can process your request. Please fix this. 🔤
|
I feel I should also take this opportunity to remind you that, as noted in our README, js.org is focusing on granting subdomain requests to projects with a clear relation to the JavaScript ecosystem and community. Projects such as personal pages, blogs, and Discord bot pages will no longer be accepted. Projects such as NPM packages, libraries, tools that have a clear direct relation to JavaScript, will be accepted when requesting a JS.ORG subdomain. Need a subdomain for a project that doesn't fall within the criteria for JS.ORG? Take a look at https://github.com/js-org/js.org/wiki/Similar-Services |
|
Looks like that is the page in question: https://github.com/AbdullahMethod/abdullah |
Uh oh!
There was an error while loading. Please reload this page.