Skip to content

Conversation

@timche
Copy link
Contributor

@timche timche commented Apr 24, 2018

  • There is reasonable content on the page (see: No Content)
  • I have read and accepted the ToS

The official documentation of redux-actions is now accessible on https://redux-utilities.gitbook.io/redux-actions/ and we don't need the fork anymore.

@indus indus added change This PR/issue is regarding making a change to an existing subdomain external page This PR has a target of a site that isn't GitHub Pages labels Apr 24, 2018
@indus indus changed the title update redux-actions CNAME redux-actions.js.org Apr 24, 2018
@indus indus added the question label Apr 24, 2018
@indus
Copy link
Member

indus commented Apr 24, 2018

Because this subdomain first was requested by @vinnymac it would be best if the same user could request the change as well (or at least approve it with a positive comment here).
Another way to make sure this PR is valid and in the will of the "owner" is to first remove the CNAME from the old repo to free the subdomain. But because this will bring your page temporary down until I'm able to process your new request I would also accept a file named "CNAME_WILL_BE_REMOVED" in the old repo.
Pick one of the outlined options to authorize your request.

@timche
Copy link
Contributor Author

timche commented Apr 24, 2018

Thanks for the quick reply @indus.

I fully understand your point.

Let me explain the situation:

  1. I already tried to reach @vinnymac via Twitter: https://twitter.com/timche_/status/986192103289049094, but without success.
    • Maybe he is available here on GitHub.
    • @vinnymac?
  2. In the original repo, we had problems reaching the repo owner and therefore we couldn't set up the docs there. Also see: fix #152 improve documentation redux-utilities/redux-actions#222 (comment)

In the end, redux-actions is actual owner of the docs and vinnymac.gitbooks.io/redux-actions is just a fork and temporary solution to get the docs online until we got admin access to the redux-actions repo. We're now kinda blocked to update the docs and keep them up-to-date with new versions unfortunately.

@vinnymac
Copy link
Contributor

@timche apologies, I am not active on Twitter, and I do not have an email in my inbox so I may just have those turned off.

I am able to help you, let me know where you’d like to discuss how we want to resolve this. Here, Twitter, or some other form of communication is fine by me.

@timche
Copy link
Contributor Author

timche commented Apr 24, 2018

No worries @vinnymac! Glad you are replying here :) Also thought you would be reachable on Twitter, my fault.

As @indus said:

Because this subdomain first was requested by @vinnymac it would be best if the same user could request the change as well (or at least approve it with a positive comment here).

That's what we basically need to be able to point the domain to the redux-actions repo instead to your fork :)

Also thanks a lot for starting these awesome docs!

@vinnymac
Copy link
Contributor

@timche no problem!

@indus seeing as I have blocked them long enough, I’d appreciate it if you merged this. In the future I will use your recommended CNAME file approach to resolve these kinds of situations. Thank you for making this so easy.

Looking forward to seeing the documentation get even more love soon!

@indus indus removed the question label Apr 24, 2018
@indus
Copy link
Member

indus commented Apr 24, 2018

@vinnymac I think the "CNAME file approach" never existed. While typing I forgot you are not using GH Pages. Next time I would think of @timche as an delegate of the project able to request further changes.

@timche It looks like your Gitbook is somehow misconfigured. The requested subdomain gets redirected. Maybe you should re-add the CNAME on your side.

@timche
Copy link
Contributor Author

timche commented Apr 24, 2018

@vinnymac thanks for all your effort, really appreciate it!

@indus configured and looks like working.

@indus indus merged commit 4afca1a into js-org:master Apr 25, 2018
@timche
Copy link
Contributor Author

timche commented Apr 25, 2018

Thanks @indus!

@timche timche deleted the redux-actions.js.org branch April 25, 2018 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change This PR/issue is regarding making a change to an existing subdomain external page This PR has a target of a site that isn't GitHub Pages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants