Skip to content

Conversation

@JustDeveloper1
Copy link
Contributor

@JustDeveloper1 JustDeveloper1 commented Dec 30, 2024

(work in progress, at the moment running on https://deploy-to-vercel-1-eight.vercel.app/ )
repository: https://github.com/JustStudio7/CodeShare
used custom rest api on TSX: https://api.juststudio.is-a.dev/

(another pastebin)

@MattIPv4 MattIPv4 changed the title Register codeshare.js.org codeshare.js.org Dec 30, 2024
@MattIPv4
Copy link
Member

@indus What do you think of this? I'm not sure I see how it directly relates, and as the PR description notes, it is essentially a pastebin, so will be storing arbitrary content provided by users which seems risky?

@MattIPv4 MattIPv4 added the awaiting response This PR is waiting for a response from the requester label Dec 30, 2024
@JustDeveloper1
Copy link
Contributor Author

JustDeveloper1 commented Dec 30, 2024

The content provided by the user that will be publicly visible will contain only:
Name of program code, program code that is not executed on the website, code language, and public user info: (using Clerk ( https://clerk.com/ ) for user authorization.) User's avatar, nickname, UserID, and account creation date.

  • XSS-protected.

@JustDeveloper1
Copy link
Contributor Author

JustDeveloper1 commented Dec 30, 2024

We ("JustStudio.", https://juststudio.is-a.dev/ ) will also add rules (terms) to ensure that CodeShare project is used for open source projects, rather than any discrimination or the like, and we ("JustStudio.") will ensure that users do not violate them.

@indus
Copy link
Member

indus commented Dec 30, 2024

@JustDeveloper1 In the w.i.p. I also only see a header a textfield and two buttons (that do nothing ?)
I'm having a hard time to understand what your page is about. Should users upload games that other users can play? I don't see how this has a relevancy for the JS community.

@JustDeveloper1
Copy link
Contributor Author

JustDeveloper1 commented Dec 30, 2024

@JustDeveloper1 In the w.i.p. I also only see a header a textfield and two buttons (that do nothing ?)

I'm having a hard time to understand what your page is about. Should users upload games that other users can play? I don't see how this has a relevancy for the JS community.

- Two buttons that do nothing?
- Buttons aren't working because I messed up with css.

- Should users upload games that other users can play?
- No, users should upload only code (i will add language select).

Relevancy for the js community: at least because the API was made on TypeScript Execute (TSX) (open-source: https://github.com/JustStudio7/API/blob/server/index.tsx ), and users on CodeShare will be able to upload code in JavaScript, TypeScript, and some other languages.

That two buttons should sending HTTP requests to api.juststudio.is-a.dev
For example, "load code" button should do a HTTP 'GET' request
to https://api.juststudio.is-a.dev/cs/${id} to get the saved code by id, example saved code response here: https://api.juststudio.is-a.dev/cs/1 (note: the code in response has replaced characters to prevent from XSS-attack, because it will be inserting as innerHTML in HTML element and it should not execute)

@MattIPv4
Copy link
Member

at least because the API was made on TypeScript Execute (TSX)

Most websites are built with JavaScript, be that on the frontend or on the backend -- just because it is built with JavaScript does not make it directly relevant to the ecosystem/community.

What about the site, as an end-user, is specifically relevant to a JavaScript developer more-so than a developer of any other language?

@JustDeveloper1
Copy link
Contributor Author

JustDeveloper1 commented Dec 30, 2024

What about the site, as an end-user, is specifically relevant to a JavaScript developer more-so than a developer of any other language?

I do not know, since the project is w.i.p. currently, maybe I will have any ideas while developing this project, or maybe you can suggest your ideas.
Maybe a badge "JavaScript Developer" or "JavaScript Community" next to nickname of each user who published the code on js/ts language.

@MattIPv4
Copy link
Member

If your site is still WIP, then I don't think we're going to approve a subdomain for it at this time -- once you have your content ready to go, and it is directly related to the JS ecosystem/community, then you can request a JS.org subdomain for the project :)

@JustDeveloper1
Copy link
Contributor Author

If your site is still WIP, then I don't think we're going to approve a subdomain for it at this time -- once you have your content ready to go, and it is directly related to the JS ecosystem/community, then you can request a JS.org subdomain for the project :)

Ok, if I finish site development in a few days, can this pull request remain open until the website done?

@indus
Copy link
Member

indus commented Dec 31, 2024

@JustDeveloper1 I prefer zero-inbox but "a few days" is fine. Nevertheless, the “direct connection to the JS ecosystem/community” aspect must then be clear

@indus indus added the on hold label Dec 31, 2024
added ","
@JustDeveloper1
Copy link
Contributor Author

backend done

@JustDeveloper1
Copy link
Contributor Author

now need to work on frontend

@JustDeveloper1
Copy link
Contributor Author

JustDeveloper1 commented Jan 19, 2025

@indus can I switch it to NS records?

@MattIPv4
Copy link
Member

@indus can I switch it to NS records?

We do not allocate NS records anymore, only CNAMEs.

@JustDeveloper1
Copy link
Contributor Author

oh ok

@indus
Copy link
Member

indus commented Jan 19, 2025

@JustDeveloper1 How long do you think will this take. This is open for 3 weeks now and I usually close PRs that don't have progress after 3-4 days. In case you need more time please close this and open a new PR when you are done with your page.

@JustDeveloper1
Copy link
Contributor Author

it is almost done and i think maybe pr can be merged, check https://deploy-to-vercel-1-eight.vercel.app/
but vercel requests A record pointing to 76.76.21.21, im not sure can i use CNAME record pointing to cname.vercel-dns.com instead

@indus
Copy link
Member

indus commented Jan 19, 2025

@JustDeveloper1 cname.vercel-dns.com is the way to go. There is already a bunch of those in the list.

@JustDeveloper1
Copy link
Contributor Author

ok

@JustDeveloper1
Copy link
Contributor Author

JustDeveloper1 commented Jan 19, 2025

#9467 (comment)

it is almost done and i think maybe pull request can be merged, check https://deploy-to-vercel-1-eight.vercel.app/

@indus indus removed awaiting response This PR is waiting for a response from the requester on hold labels Jan 19, 2025
@indus indus added add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages error The page requested returns an error labels Jan 19, 2025
@indus
Copy link
Member

indus commented Jan 19, 2025

I've already added your requested subdomain to JS.ORGs zonefile. But you page redirects from codeshare.js.org to www.codeshare.js.org (which doesn't exist).
I'll merge after we have "contact". Please keep this PR open

@JustDeveloper1
Copy link
Contributor Author

done

@indus indus merged commit b6cfb21 into js-org:master Jan 19, 2025
1 check passed
@indus
Copy link
Member

indus commented Jan 19, 2025

Welcome https://codeshare.js.org

@JustDeveloper1 JustDeveloper1 mentioned this pull request Jan 24, 2025
2 tasks
@JustDeveloper1 JustDeveloper1 mentioned this pull request Aug 29, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add This PR/issue is regarding adding a new subdomain error The page requested returns an error external page This PR has a target of a site that isn't GitHub Pages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants