-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
atos.js.org #9501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
atos.js.org #9501
Conversation
|
As I noted in #9500, please provide the requested details in the PR template/description, and please resolve the CI errors. You do not need to create a new PR to do that, you can edit the existing PR you have open (this one). |
|
I hadn't arranged it in alphabetical order before; now it is done. I think. |
|
You still haven't provided any information on what your site is in your pull request description, as I've asked for twice now... |
MattIPv4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Commit valid, CNAME present, site appears to have content *
* based off https://github.com/yeyTaken/atosjs/blob/master/README.md
|
My website will serve as comprehensive documentation for the AtosJS npm package, showcasing all its classes and features in detail, as outlined in the README.md file. To avoid delays in the official release of version 2, I secured the atos.js.org domain in advance, ensuring everything is ready for the public at launch. |
|
The AtosJS documentation site is located in the project structure under 'apps/guide/*'. It will be the official guide for AtosJS, developed with Next.js v14. Once it's done, I plan to host it at Vercel. I would like to confirm that it will work properly on the platform and that there are any specific methods or configurations that I need to follow to ensure proper functioning. |
|
With your pull request as it stands, you are using GitHub Pages to host your site and it appears you will be serving the README.md file as your website content. You can also use GitHub Pages to host a static Next.js site, you'll need a GitHub Action to do that, and no changes needed here. If you want to use Vercel, you'll need to have the subdomain target in the cnames_active.js file be Vercel, not GitHub Pages. |
|
Okay, thank you very much! When I deploy it on Vercel, I will modify it there. But I have one question: does the CNAME work the same way on Vercel? |
|
I suppose the same way, yes. You just add the js.org subdomain as a custom domain in your Vercel project. |
|
thanks! |
|
Welcome https://atos.js.org |
|
It's okay, I'm not in a hurry, I'm finishing the website yet. |
|
Make a new Pull-Request and change the line with the subdomain you have requested.Am 19.01.2025 04:32 schrieb Rabi ***@***.***>:
Finish the site and I've already deployed it to Vercel. How do I add the atos.js.org domain in Vercel?
image.png (view on web)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|


Uh oh!
There was an error while loading. Please reload this page.