Skip to content

Conversation

@ihasq
Copy link
Contributor

@ihasq ihasq commented Jan 19, 2025

The site content is ... Opensource Project Page

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/ihasq/libh/tree/main/docs

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels Jan 19, 2025
@indus indus added the error The page requested returns an error label Jan 19, 2025
@indus
Copy link
Member

indus commented Jan 19, 2025

I've already added your requested subdomain to JS.ORGs zonefile. But your page throws an error. So I'm unable to get an idea of the content. Please fix that to give me a chance to have a look.
I'll merge after we have "contact".

Please keep this PR open.

@JustDeveloper1
Copy link
Contributor

it already runs on https://libh.js.org
image

@indus
Copy link
Member

indus commented Jan 19, 2025

@JustDeveloper1 I've checked in Firefox.

-> Uncaught TypeError: c.attributeStyleMap is undefined

Nice dogfooding - but nevertheless, welcome https://libh.js.org

@indus indus merged commit 281d21f into js-org:master Jan 19, 2025
1 check passed
@ihasq
Copy link
Contributor Author

ihasq commented Jan 20, 2025

Thx for approving
I'll fix it

@ihasq
Copy link
Contributor Author

ihasq commented Jan 20, 2025

fixed: https://libh.js.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add This PR/issue is regarding adding a new subdomain error The page requested returns an error project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants