feat: add TypeScript typings and ES6 class extension support for Http Error #139
+75
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
UlisesGascon
left a comment
UlisesGascon
left a comment
There was a problem hiding this comment.
Can we include some kind of testing for the types in a dedicated pipeline? WDYT @wesleytodd @jonchurch
| }) | ||
|
|
||
| it('new createError.HttpError()', function () { | ||
| assert.throws(function () { |
Member
There was a problem hiding this comment.
Note: This a semver major change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive TypeScript type definitions directly to the package and enables proper ES6 class extension for HttpError, resolving issues #98 and #100. The implementation replaces the old function-based HttpError with a proper ES6 class, allowing users to extend HttpError without abstract class restrictions. TypeScript definitions are provided in index.d.ts with full CommonJS export support and complete type coverage for all functions and overloads. All existing functionality remains backward compatible with 100% test coverage maintained and new tests added for both TypeScript integration and ES6 class extension scenarios. Users can now import TypeScript types directly from the package without requiring
@types/http-errorsand can properly extend HttpError classes with full prototype chain inheritance.Fixes: