Skip to content

fix: handle NaN status codes by defaulting to 500 #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ayoub-Mabrouk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: handle NaN status codes by defaulting to 500 #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ function createError () {
deprecate('non-error status code; use only 4xx or 5xx status codes')
}

if (typeof status !== 'number' ||
if (typeof status !== 'number' || isNaN(status) ||
(!statuses.message[status] && (status < 400 || status >= 600))) {
status = 500
}
Expand Down
9 changes: 9 additions & 0 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,15 @@ describe('HTTP Errors', function () {
assert.strictEqual(err.expose, false)
})

it('createError(NaN) should default to 500', function () {
var err = createError(NaN)
assert.strictEqual(err.name, 'InternalServerError')
assert.strictEqual(err.message, 'Internal Server Error')
assert.strictEqual(err.status, 500)
assert.strictEqual(err.statusCode, 500)
assert.strictEqual(err.expose, false)
})

it('createError(err, props)', function () {
var _err = new Error('LOL')
_err.status = 404
Expand Down
Loading