Skip to content

Conversation

@bart-degreed
Copy link
Contributor

@bart-degreed bart-degreed commented Jan 6, 2020

Closes #650

FEATURE

  • Made AttrAttribute.PropertyInfo public and removed AttrAttribute.InternalAttributeName.
  • Removed unused interface IRelationshipField.

@bart-degreed
Copy link
Contributor Author

@maurei I was unable to run all tests locally, because I do not have pgsql installed. If they do not run automatically during PR build, someone should try them before merging this in.

Copy link
Member

@maurei maurei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When merging to master the CI pipeline runs the tests in the cloud: they all pass. I replied to the testing issue in my reply to your message in our gitter channel

@maurei maurei merged commit 2b64e03 into json-api-dotnet:master Jan 9, 2020
@bart-degreed bart-degreed deleted the attr-property-info branch January 9, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: publicly expose AttrAttribute.PropertyInfo getter

2 participants