Various code cleanups in preparation of auto-formatting the codebase #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
February 15, 2021 11:29
…gth on database queries in tests
Resharper was set to auto-detect, making it ignore configured rules
…955) Corrected link rendering for hosting inside an IIS application virtual directory
added 24 commits
February 25, 2021 12:29
…ike 'member can be private, set accessor is never used'etc.
…nly used for precondition checks' Note that one suppression is needed, due to a bug in Resharper
…ause these are assigned once at application startup by the resource graph builder and then are considered immutable.
…mber can be made internal', 'type has no inheritors and can be marked sealed', 'member is never written to' etc.
…r an open generic for them to enable different implementations per resource type.
…ld find the line that calls Subject.StatusCode.Should().Be() and treat the Subject variable as the subject-under-test (SUT). But by applying this attribute, it will ignore this invocation and instead find the SUT by looking for a call to Should().HaveStatusCode() and use the response variable instead.
maurei
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.