Added cache system for schema loader. #1162
Conversation
chhill-redhat
force-pushed
the
feature/schema-loader-cache-results
branch
2 times, most recently
from
92e3ade to
76d575e
Compare
chhill-redhat
force-pushed
the
feature/schema-loader-cache-results
branch
from
bc1b7fe to
6b0e7d1
Compare
|
@schmunk42 , this is ready for review. Tests pass locally (unit and e2e). |
|
Hi @chhill-redhat, Because the whole functionality of the json-editor depends on the schema-loader component, this PR will take a little more time to review as usual. We will give you feedback as soon as possible. |
|
@germanbisurgi , thank you for the update! |
|
Hi @germanbisurgi wondering if there are any updates on this PR. Thanks. |
|
Hi @germanbisurgi and @schmunk42, has there been any more opportunity to review and test this work to get it pushed forward? What are the best next steps to get this pushed forward? |
|
Sorry guys for the delay, we were just not able to find enough time to review. @chhill-redhat |
|
@schmunk42 , no worries! You're right, it's BC by default, because the cache is disabled unless explicitly enabled. |
|
@chhill-redhat Available in |
|
Great. Thank you, @schmunk42 ! Really appreciate it. |
5 participants
Summary
This PR allows the schema loader to cache external schemas which were fetched by Ajax calls. The cache is the browser's
localStoragestorage. Caching is opt-in feature. By default, the caches are valid only for the current calendar day. However, the consumer can pass an explicit cache buster (e.g., the cache buster can be a hash of the schemas, to invalidate caches when any schema changes).