Update LessThanRule.cs

[alexkharuk]

Fx the bug/typo with comparing for LessThenRule with two parameters

Description

LessThenRule
JsonNode? IRule.Apply(JsonNode? args, EvaluationContext context) method
comparing two equals strings returns true, but should be false

Links

916

Checks

• I have read and understand the Code of Conduct and Contribution Guidelines.

[gregsdennis]

@alexkharuk why open another project with the same change? The tests still need to be addressed.

[alexkharuk]

@gregsdennis sorry i was under impression that all are ok.
i have recreated this mr but still see the same error: Error: HttpError: Resource not accessible by integration
it looks to me that i do not have some permissions or missed something and can pass test report step.
anyway all business logic tests looks good and green

[gregsdennis]

Oh, yes, sorry. I thought the tests were failing. It's just a permissions issue with paying back to the PR.

It's odd that the tests weren't failing before.

[alexkharuk]

@gregsdennis let me know if i can do anything to push it over

[alexkharuk]

@dotnet-policy-service agree

[alexkharuk]

I have added two test cases to the more-tests.json

[alexkharuk]

@gregsdennis it looks like comparison of strings never was fully covered with the tests. I have added few more tests, hope you do not mind.

[gregsdennis]

@alexkharuk please update the patch version (5.4.1) in the project file and release notes. Feel free to credit yourself in the notes. Then I can merge this and it will publish the update.

[alexkharuk]

@gregsdennis I have updated version and release notes.