Skip to content

Conversation

@BigBlueHat
Copy link
Member

@BigBlueHat BigBlueHat commented Nov 18, 2025

No description provided.

@BigBlueHat BigBlueHat requested a review from davidlehn November 18, 2025 19:23
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 18, 2025

Deploying json-ld-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: e37bd56
Status: ✅  Deploy successful!
Preview URL: https://4293a746.json-ld-org.pages.dev
Branch Preview URL: https://update-all-the-things.json-ld-org.pages.dev

View logs

@davidlehn
Copy link
Member

Why is the built editor.bundle.js file in git? I didn't notice that before. Looks like it could be built into the output _site dir and avoid huge churn in git history.

@BigBlueHat
Copy link
Member Author

Why is the built editor.bundle.js file in git? I didn't notice that before. Looks like it could be built into the output _site dir and avoid huge churn in git history.

Yeah. Not sure what my reasoning was earlier, but it is annoying to not have it built automatically with the rest. I'm planning on switching to using https://github.com/Snapstromegon/eleventy-plugin-rollup in another PR, but I'd appreciate not having to go backwards and rewrite all this history.

If there are no other objections, would you mind approving this one?

@BigBlueHat BigBlueHat force-pushed the update-all-the-things branch from 242a8e4 to 13c1fec Compare November 21, 2025 19:26
@BigBlueHat
Copy link
Member Author

@davidlehn the editor.bundle.js is not built just prior to the rest of the site and no longer in the commit log.

We can dig into #885 as a separate task/exploration.

@BigBlueHat BigBlueHat merged commit 10c2d9e into main Nov 21, 2025
1 check passed
@BigBlueHat BigBlueHat deleted the update-all-the-things branch November 21, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants