Fix for logical operator priorities and issue #175 #177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first fix is for test
assertThat(compile("[?((@.a && @.b || @.c) || @.x)]").toString()).isEqualTo("[?(((@['a'] && @['b']) || @['c']) || @['x'])]");The thing is logical OR should has lower priority than logical AND. It seemed entire top-level filter parsing (
FilterCompiler.compile) was not aware of priorities. So it was reimplemented 'by hand' using backtracking and the following grammar:The second fix is for issue #175 . I've added
iftoSizeEvaluator, but also acatchblock inPredicatePathToken.acceptso that problem with criteria evaluation for one array element would't prematurely stop filtering routine.