Add keys function for Map objects #440
Merged
+55
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinivasarajuch
approved these changes
Aug 8, 2018
srinivasarajuch
left a comment
srinivasarajuch
left a comment
There was a problem hiding this comment.
Looks good, why this PR is not merged.
|
is this good? can you merge? |
|
I really need this function, can you merge,? thanks |
jamesanto
reviewed
Nov 27, 2020
| public void testKeySet() throws Exception { | ||
| String json = IOUtils.toString(getClass().getResourceAsStream("/keyset.json")); | ||
| verifyFunction(conf, "$.data.keys()", json, new HashSet<String>(Arrays.asList("a", "b"))); | ||
| } |
There was a problem hiding this comment.
some additional negative cases would be better
Merged
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #439