Skip to content

Conversation

@Dervisevic
Copy link
Contributor

Changed so that some types(Like radiobuttons, checkboxes etc) can have HTML in title. Changed so that all can have it in description. Updated tests for this. Updated bootstrap examples to feature these changes.

… description. Updated tests for this. Updated bootstrap examples.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Div is not a good choice here. Even if title would contain HTML code, a span would be more reasonable with title.

From json-schema definition: "A title will preferrably be short"

and about div in label:
http://stackoverflow.com/questions/18609554/is-div-inside-label-block-correct

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually had this discussion with @davidlgj. The reason we landed on div was due to us feeling it needed to be a block element, mainly due to stuff like line breaks or other things that semantically should not be in a inline element like a span. Thoughts?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say that a title should never contain block level elements. A description could, but description is never put in a label here what I can see.

Technically, you can't be sure of what the user puts in the title, but if they make the title block-level, they deserve broken html ;)

davidlgj added a commit that referenced this pull request Jul 4, 2014
Support HTML in titles and descriptions
@davidlgj davidlgj merged commit dc4fa94 into development Jul 4, 2014
@Dervisevic Dervisevic deleted the feature/sanitationServices branch July 6, 2014 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants