Skip to content

Conversation

@albsod
Copy link

@albsod albsod commented Feb 19, 2015

These commits

  1. add javascript sources and license information following the FSFs guidelines (https://www.gnu.org/software/librejs/free-your-javascript.html). This lets the users a) examine what code gets exectuted in their browser and b) learn what code is available under a free license, so as to facilitate copying. With the added sources and license information users of the GNU LibreJS add-on, which blocks non-free javascript by default, will also be able to display the website correctly (with the exception of Twitter's follow button which doesn't seem to be free).
  2. change a few http URLs to https
  3. fix indentation here and there.

@albsod
Copy link
Author

albsod commented Feb 19, 2015

By the way, "dist/bootstrap-decorator.js" does not appear to be the source file for "dist/bootstrap-decorator.min". (In "jslicense.html" I say it is.)

@Dervisevic
Copy link
Contributor

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is all of the code changed? Or at least why is it in the diff? It makes it very hard to see if you changed any code or not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh did you use some kind of code formatter? It looks like a lot of empty lines have disappeared, that might be the problem.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I did some indentation cleaning, but I realize now that I shouldn't have done that. Too many different changes makes it harder for you to see exactly what I did. Those lines above that are marked as deleted should still exist in the file.

Dervisevic added a commit that referenced this pull request Mar 6, 2015
Add license information for LibreJS compatibility.
@Dervisevic Dervisevic merged commit 580edab into json-schema-form:gh-pages Mar 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants