Skip to content

Conversation

@dwikle
Copy link
Contributor

@dwikle dwikle commented Apr 15, 2015

I'm not an expert with requirejs but this worked for me to get angular-schema-form to play nice with ObjectPath in a project that uses requirejs.

I ran gulp and committed in dist/. It wasn't clear to me if that should be in the pull request.

@Dervisevic
Copy link
Contributor

Sorry, should make it more clear, don't add the dist files to the PR, we do that before every release.

On Wed, Apr 15, 2015 at 7:37 PM, Doug Wikle notifications@github.com
wrote:

I'm not an expert with requirejs but this worked for me to get angular-schema-form to play nice with ObjectPath in a project that uses requirejs.
I ran gulp and committed in dist/. It wasn't clear to me if that should be in the pull request.
You can view, comment on, or merge this pull request online at:
#354
-- Commit Summary --

This reverts commit c2a9dfd.
@dwikle
Copy link
Contributor Author

dwikle commented Apr 15, 2015

I reverted the files in dist/. Assuming this gets merged, what the procedure for getting an updated release?

@Dervisevic
Copy link
Contributor

We usually collect a bunch of commits and PRs and try to do a release every 2 weeks or so. We are trying to get one out soon and I think this will be reviewed before that so yeah. If you wanna know when a release has been made follow http://twitter.com/SchemaFormIO.

Dervisevic added a commit that referenced this pull request Apr 16, 2015
Add UMD module wrapper to support requirejs
@Dervisevic Dervisevic merged commit adfc4ea into json-schema-form:development Apr 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants