Skip to content

change folder to baseUriChange #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2020
Merged

change folder to baseUriChange #441

merged 2 commits into from
Oct 23, 2020

Conversation

@plxel
Copy link
Contributor

@plxel plxel commented Oct 11, 2020

It should fix Error: Cannot find module './remotes/folder/folderInteger.json'

notEthan
notEthan approved these changes Oct 11, 2020
View reviewed changes
Copy link
Contributor

@notEthan notEthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like I missed this in #360. lgtm.

@Julian Julian merged commit 0f35b32 into json-schema-org:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@notEthan notEthan notEthan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@plxel @notEthan @Julian