Fix the shortcut form of #render #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaximov
changed the title
beauby
approved these changes
May 25, 2017
| # @api private | ||
| def rails_renderer(renderer) | ||
| proc do |json, options| | ||
| reverse_mapping = request.env[ActionController::REVERSE_MAPPING_KEY] |
Member
There was a problem hiding this comment.
Would you mind adding a comment stating that the proc is instance_eval'd in the controller context? It will simplify debugging in case this assumption is broken by rails at some point.
Contributor
Author
There was a problem hiding this comment.
Should I squash commits?
Member
|
Thanks, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #24