Skip to content

Conversation

@beauby
Copy link
Member

@beauby beauby commented Jul 13, 2017

  • Use dependency injection in renderer wrappers.
  • Make renderer wrappers classes and reuse renderers.

JSONAPI::Serializable::ErrorRenderer.render(errors, options)
end
end
class ErrorsRenderer

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing top-level class documentation comment.

@beauby beauby merged commit 927f030 into master Jul 13, 2017
@beauby beauby deleted the update-renderer branch July 13, 2017 16:39
mdeutsch pushed a commit to patientslikeme/jsonapi-rails that referenced this pull request Jul 21, 2017
* upstream/master:
  Improve specs (jsonapi-rb#33)
  Expose deserialization reverse mapping in controllers (jsonapi-rb#29)
  Update jsonapi-rb to v0.2.1. (jsonapi-rb#32)
  Add dummy app temp files to .gitignore (jsonapi-rb#30)
  Deal with jsonapi-serializable no longer calling to_json (jsonapi-rb#26)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants