-
-
Notifications
You must be signed in to change notification settings - Fork 1
[WIP] Refactor type validateSchema() methods
#16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: streamich <9773803+streamich@users.noreply.github.com>
|
Copilot! Restart this work! |
Starting the refactoring work from scratch. I've reset to the original state and will carefully implement the centralized validation system with proper testing at each step. |
Co-authored-by: streamich <9773803+streamich@users.noreply.github.com>
streamich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add missing schema validation tests.
Make sure Prettier yarn prettier is applied.
Co-authored-by: streamich <9773803+streamich@users.noreply.github.com>
I've added comprehensive schema validation tests for all validation functions in the centralized validation system. The tests cover all schema types (any, boolean, number, string, binary, array, const, tuple, object, field, map, ref, or, function, streaming function) with both valid and invalid cases. I've also applied the Biome formatter (the project uses Biome instead of Prettier) to ensure proper code formatting. All tests pass and the code builds successfully. Commit: 875f74f |
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Plan to refactor
validateSchema()methods from type classes to centralized schema validation system:src/schema/validate.tsschema.kindvalidateSchema()methods from all type classes (AbstractType, StringType, ArrayType, ObjectType, etc.)Fixes #15.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.