-
Notifications
You must be signed in to change notification settings - Fork 152
Polish a few corner cases #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ansell I think the Changelog could be clearer if it was organized by version instead of date, and was in a separate file. I tend to follow these guidelines which really help me... (an example), but that not crucial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to preserve the custom test added in #168, otherwise looks good.
}, | ||
"@type": "ex:Library", | ||
"ex:contains": { | ||
"@explicit":true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My impression was that this test file was intended to be a custom test. However, it seems to have mistakenly landed in core/src/test/resources/json-ld.org/
instead of core/src/test/resources/custom
. The PR which included it was #168 by @hmottestad for background reference.
Could you move it to core/src/test/resources/custom
as part of this PR?
Thanks for your comments, the test is back as a custom test |
The error in travis-ci is a network error and, I think, can be ignored (nothing to do with this PR) |
Thanks, the changes look good and the Travis-CI error retrieving from purl.org is intermittent (it worked for JDK8), and not likely related to JDK9 in that case given it worked previously. I will merge this in and release 0.11.0 today. |
Thanks, great to see a new release! |
This is the final PR for me. @hmottestad I've integrated and completed your PR (#207) in it. It doesn't do anything with the
@requireAll
flag, but at least it should have a less buggy behavior. The flag is passed as an argument offilterNode
inJsonLdApi.java
, but this function requires some heavy lifting to properly align with the Frame Matching algorithm of JSON-LD 1.1. If you want to really handle the flag, that's where you need to change things.