Skip to content

feat: allow mixed iterable in chain function #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2024
Merged

feat: allow mixed iterable in chain function #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion async/chain.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* ```
*/
export async function* chain<T>(
...iterables: Iterable<T>[] | AsyncIterable<T>[]
...iterables: (Iterable<T> | AsyncIterable<T>)[]
): AsyncIterable<T> {
for await (const iterable of iterables) {
for await (const value of iterable) {
Expand Down
11 changes: 11 additions & 0 deletions async/chain_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,15 @@ Deno.test("chain", async (t) => {
assertEquals(await toArray(result), expected);
assertType<IsExact<typeof result, AsyncIterable<number>>>(true);
});

await t.step("with mixed iterable", async () => {
const result = chain(
toAsyncIterable([1, 2]),
[3, 4],
toAsyncIterable([5]),
);
const expected = [1, 2, 3, 4, 5];
assertEquals(await toArray(result), expected);
assertType<IsExact<typeof result, AsyncIterable<number>>>(true);
});
});