Skip to content

Conversation

@BorisLord
Copy link
Contributor

Fullscreen view (almost) unchanged
Button was oversized on smaller screen

Before :
image

After :
image

@AugustinMauroy
Copy link
Contributor

I'm the one who implemented this and I did it voluntarily. Why did you do it? Because it makes the button more accessible on mobile (by increasing its size) because it's finger-operated. And on desktop/large screens, you don't need a huge click zone. That's why it's smaller/discreet.

@BorisLord
Copy link
Contributor Author

I believe the button size is not consistent with the other buttons on the page, such as the "use with" button.
If buttons need to be larger for mobile use, we should review all button sizes to keep the user experience consistent.
In my opinion, the button is too large on mobile, but it's okay if you think a larger button is better for the user experience.

@BorisLord BorisLord closed this Mar 2, 2025
Copy link
Contributor

@EGAMAGZ EGAMAGZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As you also have a good point regarding its dimensions and its relationship to the other buttons.

@BorisLord BorisLord reopened this Mar 2, 2025
Copy link
Collaborator

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds reasonable, LGTM

@crowlKats crowlKats added this pull request to the merge queue Mar 11, 2025
Merged via the queue into jsr-io:main with commit 9918be4 Mar 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants