Add forbidPatterns to forbid-component-props rule #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Nov 1, 2016
Adds a forbidPatterns option that takes an array of safe pattern strings so it's possible to forbid the use of things like "data-*" props. Also adds the ignoreDomNodes option (defaults to true), because sometimes we do want to check forbidden props on DOM nodes i.e. for "data-*" so we can avoid tying implementation to thirdparty libraries that work on the DOM.
burabure
force-pushed
the
forbid-component-props-forbidPatterns
branch
from
098a123 to
3deeb99
Compare
ljharb
requested changes
Nov 1, 2016
|
all changes done. |
ljharb
requested changes
Nov 2, 2016
|
|
||
| ### `ignoreComponents` | ||
|
|
||
| Whether to skip checking forbidden props on Components (div, input, span, etc...). Defaults to false. |
There was a problem hiding this comment.
these examples are DOM nodes, not Components
| var tag = node.parent.name.name; | ||
| if (tag && tag[0] !== tag[0].toUpperCase()) { | ||
| // This is a DOM node, not a Component, so exit. | ||
| var isComponent = tag && tag[0] === tag[0].toUpperCase(); |
There was a problem hiding this comment.
i think your code here is making the false assumption that there's only two kinds of nodes, DOM and Component. nodes can also be strings, numbers, arrays… are we sure this is the right way to check "is dom node" and "is component"? I feel like we have functions for this in the codebase already.
ljharb
reviewed
Nov 2, 2016
|
|
||
| Whether to check forbidden props on DOM nodes (div, input, span, etc...). Defaults to false. | ||
|
|
||
| ### `ignoreComponents` |
|
I dont have time to refactor according to #850. if anyone want to do it please do =) |
ljharb
force-pushed
the
master
branch
6 times, most recently
from
59af733 to
865ed16
Compare
ljharb
force-pushed
the
master
branch
4 times, most recently
from
069314a to
181c68f
Compare
ljharb
force-pushed
the
master
branch
2 times, most recently
from
380e32c to
51d342b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a forbidPatterns option that takes an array of regexp strings so it's possible to forbid the use of things like
data-*props