Fix parser error when passing parameters to FETCH #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in this StackOverflow post: http://stackoverflow.com/questions/26183675/error-when-fetching-subject-from-email-using-haskellnets-imap Passing parameters to the query string you use in `fetchByString` would break the parser which was splitting input on spaces regardless of whether it was inside square brackets so a response like "* 2 FETCH (UID 2 BODY[HEADER.FIELDS (SUBJECT)] {43}\r" would be split into: UID 2 BODY[HEADER.FIELDS (SUBJECT)] {43} #ERROR (No value) This commit simply includes anything in square brackets as part of the key, so that the above string would be split as follows: UID 2 BODY[HEADER.FIELDS (SUBJECT)] {43}
jtdaugherty
added a commit
that referenced
this pull request
Oct 7, 2014
Fix parser error when passing parameters to FETCH
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in this StackOverflow post:
http://stackoverflow.com/questions/26183675/error-when-fetching-subject-from-email-using-haskellnets-imap
Passing parameters to the query string you use in
fetchByStringwouldbreak the parser which was splitting input on spaces regardless of
whether it was inside square brackets so a response like
would be split into:
This commit simply includes anything in square brackets as part of the
key, so that the above string would be split as follows: