🐛 mypy linting

Author: juftin

lunchable/_cli.py

@@ -4,7 +4,7 @@
 
 import logging
 from json import JSONDecodeError
-from typing import Optional
+from typing import Any, Dict, Optional, Union
 
 import click
 import requests
@@ -58,14 +58,14 @@ def cli(ctx: click.core.Context, debug: bool, access_token: str) -> None:
 
 
 @cli.group()
-def transactions():
+def transactions() -> None:
     """
     Interact with Lunch Money transactions
     """
 
 
 @cli.group()
-def plugins():
+def plugins() -> None:
     """
     Interact with Lunchable Plugins
     """
@@ -133,17 +133,19 @@ def plugins():
     help="Pass in true if you’d like to include imported transactions with a pending status.",
 )
 @click.pass_obj
-def lunchmoney_transactions(context: LunchMoneyContext, **kwargs):
+def lunchmoney_transactions(
+    context: LunchMoneyContext, **kwargs: Dict[str, Any]
+) -> None:
     """
     Retrieve Lunch Money Transactions
     """
     lunch = LunchMoney(access_token=context.access_token)
-    transactions = lunch.get_transactions(**kwargs)
+    transactions = lunch.get_transactions(**kwargs)  # type: ignore[arg-type]
     print_json(data=transactions, default=pydantic_encoder)
 
 
 @plugins.group()
-def splitlunch():
+def splitlunch() -> None:
     """
     Splitwise Plugin for lunchable, SplitLunch 💲🍱
     """
@@ -178,7 +180,7 @@ def splitlunch():
     default=None,
     help="ISO 8601 Date time. Return expenses updated before this date",
 )
-def splitlunch_expenses(**kwargs):
+def splitlunch_expenses(**kwargs: Union[int, str, bool]) -> None:
     """
     Retrieve Splitwise Expenses
     """
@@ -187,7 +189,7 @@ def splitlunch_expenses(**kwargs):
     splitlunch = SplitLunch()
     if set(kwargs.values()) == {None}:
         kwargs["limit"] = 5
-    expenses = splitlunch.get_expenses(**kwargs)
+    expenses = splitlunch.get_expenses(**kwargs)  # type: ignore[arg-type]
     print_json(data=expenses, default=pydantic_encoder)
 
 
@@ -217,7 +219,7 @@ def splitlunch_expenses(**kwargs):
 
 @splitlunch.command("splitlunch")
 @tag_transactions
-def make_splitlunch(**kwargs):
+def make_splitlunch(**kwargs: Union[int, str, bool]) -> None:
     """
     Split all `SplitLunch` tagged transactions in half.
 
@@ -226,7 +228,7 @@ def make_splitlunch(**kwargs):
     from lunchable.plugins.splitlunch import SplitLunch
 
     splitlunch = SplitLunch()
-    results = splitlunch.make_splitlunch(**kwargs)
+    results = splitlunch.make_splitlunch(**kwargs)  # type: ignore[arg-type]
     print_json(data=results, default=pydantic_encoder)
 
 
@@ -235,7 +237,7 @@ def make_splitlunch(**kwargs):
 @financial_partner_id
 @financial_partner_email
 @financial_partner_group_id
-def make_splitlunch_import(**kwargs):
+def make_splitlunch_import(**kwargs: Union[int, str, bool]) -> None:
     """
     Import `SplitLunchImport` tagged transactions to Splitwise and Split them in Lunch Money
 
@@ -245,15 +247,21 @@ def make_splitlunch_import(**kwargs):
     """
     from lunchable.plugins.splitlunch import SplitLunch
 
-    financial_partner_id = kwargs.pop("financial_partner_id")
-    financial_partner_email = kwargs.pop("financial_partner_email")
-    financial_partner_group_id = kwargs.pop("financial_partner_group_id")
+    financial_partner_id: Optional[int] = kwargs.pop(
+        "financial_partner_id"
+    )  # type: ignore[assignment]
+    financial_partner_email: Optional[str] = kwargs.pop(
+        "financial_partner_email"
+    )  # type: ignore[assignment]
+    financial_partner_group_id: Optional[int] = kwargs.pop(
+        "financial_partner_group_id"
+    )  # type: ignore[assignment]
     splitlunch = SplitLunch(
         financial_partner_id=financial_partner_id,
         financial_partner_email=financial_partner_email,
         financial_partner_group_id=financial_partner_group_id,
     )
-    results = splitlunch.make_splitlunch_import(**kwargs)
+    results = splitlunch.make_splitlunch_import(**kwargs)  # type: ignore[arg-type]
     print_json(data=results, default=pydantic_encoder)
 
 
@@ -262,7 +270,7 @@ def make_splitlunch_import(**kwargs):
 @financial_partner_id
 @financial_partner_email
 @financial_partner_group_id
-def make_splitlunch_direct_import(**kwargs):
+def make_splitlunch_direct_import(**kwargs: Union[int, str, bool]) -> None:
     """
     Import `SplitLunchDirectImport` tagged transactions to Splitwise and Split them in Lunch Money
 
@@ -272,20 +280,26 @@ def make_splitlunch_direct_import(**kwargs):
     """
     from lunchable.plugins.splitlunch import SplitLunch
 
-    financial_partner_id = kwargs.pop("financial_partner_id")
-    financial_partner_email = kwargs.pop("financial_partner_email")
-    financial_partner_group_id = kwargs.pop("financial_partner_group_id")
+    financial_partner_id: Optional[int] = kwargs.pop(
+        "financial_partner_id"
+    )  # type: ignore[assignment]
+    financial_partner_email: Optional[str] = kwargs.pop(
+        "financial_partner_email"
+    )  # type: ignore[assignment]
+    financial_partner_group_id: Optional[int] = kwargs.pop(
+        "financial_partner_group_id"
+    )  # type: ignore[assignment]
     splitlunch = SplitLunch(
         financial_partner_id=financial_partner_id,
         financial_partner_email=financial_partner_email,
         financial_partner_group_id=financial_partner_group_id,
     )
-    results = splitlunch.make_splitlunch_direct_import(**kwargs)
+    results = splitlunch.make_splitlunch_direct_import(**kwargs)  # type: ignore[arg-type]
     print_json(data=results, default=pydantic_encoder)
 
 
 @splitlunch.command("update-balance")
-def update_splitwise_balance(**kwargs):
+def update_splitwise_balance() -> None:
     """
     Update the Splitwise Asset Balance
     """
@@ -297,7 +311,7 @@ def update_splitwise_balance(**kwargs):
 
 
 @splitlunch.command("refresh")
-def refresh_splitwise_transactions(**kwargs):
+def refresh_splitwise_transactions() -> None:
     """
     Import New Splitwise Transactions to Lunch Money and
 
@@ -313,7 +327,7 @@ def refresh_splitwise_transactions(**kwargs):
 
 
 @plugins.group()
-def pushlunch():
+def pushlunch() -> None:
     """
     Push Notifications for Lunch Money: PushLunch 📲
     """
@@ -338,7 +352,7 @@ def pushlunch():
     default=None,
     help="Pushover User Key. Defaults to `PUSHOVER_USER_KEY` env var",
 )
-def notify(continuous: bool, interval: int, user_key: str):
+def notify(continuous: bool, interval: int, user_key: str) -> None:
     """
     Send a Notification for each Uncleared Transaction
     """
@@ -355,7 +369,7 @@ def notify(continuous: bool, interval: int, user_key: str):
 @click.option("-X", "--request", default="GET", help="Specify request command to use")
 @click.option("-d", "--data", default=None, help="HTTP POST data")
 @click.pass_obj
-def http(context: LunchMoneyContext, url: str, request: str, data: str):
+def http(context: LunchMoneyContext, url: str, request: str, data: str) -> None:
     """
     Interact with the LunchMoney API
 
@@ -386,7 +400,7 @@ def http(context: LunchMoneyContext, url: str, request: str, data: str):
 
 
 @plugins.group()
-def primelunch():
+def primelunch() -> None:
     """
     PrimeLunch CLI - Syncing LunchMoney with Amazon
     """

lunchable/_config/api_config.py

@@ -86,7 +86,7 @@ def get_header(access_token: Optional[str] = None) -> Dict[str, str]:
         return auth_header
 
     @staticmethod
-    def make_url(url_path: Union[List[Union[str, int]], str, int]):
+    def make_url(url_path: Union[List[Union[str, int]], str, int]) -> str:
         """
         Make a Lunch Money API URL using path parts
 
@@ -126,7 +126,7 @@ def _generate_url(
         params: str = "",
         query: str = "",
         fragment: str = "",
-    ):
+    ) -> str:
         """
         Build a URL
 

lunchable/models/_base.py

@@ -10,7 +10,7 @@ class LunchableModel(BaseModel):
     Hashable Pydantic Model
     """
 
-    def __hash__(self):
+    def __hash__(self) -> int:
         """
         Hash Method for Pydantic BaseModels
         """

lunchable/models/_core.py

@@ -6,7 +6,7 @@
 import json
 import logging
 from json import loads
-from typing import Any, List, Optional, Union
+from typing import Any, Dict, List, Optional, Union
 
 import requests
 
@@ -76,7 +76,7 @@ def __repr__(self) -> str:
         return "<LunchMoney: requests.Session>"
 
     @staticmethod
-    def _serializer(obj):
+    def _serializer(obj: Any) -> str:
         if isinstance(obj, datetime.datetime):
             return obj.isoformat()
         elif isinstance(obj, datetime.date):
@@ -88,9 +88,9 @@ def _make_request(
         self,
         method: str,
         url_path: Union[List[Union[str, int]], str, int],
-        params: Optional[dict] = None,
+        params: Optional[Dict[str, Any]] = None,
         payload: Optional[Any] = None,
-        **kwargs
+        **kwargs: Any
     ) -> Any:
         """
         Make a Request to the API
@@ -102,7 +102,7 @@ def _make_request(
             PATCH, or DELETE
         url_path: Union[List[Union[str, int]], str, int]
             API Components, if a list join these sequentially
-        params: Optional[dict]
+        params: Optional[Dict[str, Any]]
             Params to pass
         payload: Optional[Any]
             data to pass
@@ -143,7 +143,7 @@ def make_http_request(
         params: Optional[Any] = None,
         data: Optional[Any] = None,
         json: Optional[Any] = None,
-        **kwargs
+        **kwargs: Any
     ) -> requests.Response:
         """
         Make a HTTP Request

lunchable/models/assets.py

@@ -6,7 +6,7 @@
 
 import datetime
 import logging
-from typing import List, Optional
+from typing import List, Optional, Union
 
 from pydantic import Field, validator
 
@@ -87,7 +87,7 @@ class _AssetsParamsPut(LunchableModel):
 
     @classmethod
     @validator("balance", pre=True)
-    def result_check(cls, x):
+    def result_check(cls, x: Union[float, int]) -> float:
         """
         Check a result
         """
@@ -112,7 +112,7 @@ class _AssetsParamsPost(LunchableModel):
 
     @classmethod
     @validator("balance", pre=True)
-    def result_check(cls, x):
+    def result_check(cls, x: Union[float, int]) -> float:
         """
         Check a result
         """

lunchable/models/transactions.py

@@ -446,7 +446,7 @@ def get_transactions(
         limit: Optional[int] = None,
         debit_as_negative: Optional[bool] = None,
         pending: Optional[bool] = None,
-        params: Optional[dict] = None,
+        params: Optional[Dict[str, Any]] = None,
     ) -> List[TransactionObject]:
         """
         Get Transactions Using Criteria

lunchable/plugins/base/base_app.py

@@ -38,7 +38,7 @@ class LunchableDataModel(LunchableModel):
     """
 
     model: Type[LunchableModel]
-    function: Callable
+    function: Callable[[Any], Any]
     kwargs: Dict[str, Any] = {}
 
 
@@ -77,7 +77,7 @@ class BaseLunchableApp(ABC):
     Abstract Base Class for Lunchable Apps
     """
 
-    __lunchable_object_mapping__: dict[str, str] = {
+    __lunchable_object_mapping__: Dict[str, str] = {
         PlaidAccountObject.__name__: "plaid_accounts",
         TransactionObject.__name__: "transactions",
         CategoriesObject.__name__: "categories",
@@ -133,7 +133,7 @@ def __init__(self, cache_time: int = 0, access_token: Optional[str] = None):
     def _cache_single_object(
         self,
         model: Type[LunchableModelType],
-        function: Callable,
+        function: Callable[[Any], Any],
         kwargs: Optional[Dict[str, Any]] = None,
         force: bool = False,
     ) -> Union[LunchableModelType, List[LunchableModelType]]:
@@ -144,7 +144,7 @@ def _cache_single_object(
         ----------
         model: Type[LunchableModel]
         function: Callable
-        kwargs: dict[str, Any]
+        kwargs: Optional[Dict[str, Any]]
         force: bool
 
         Returns
@@ -166,7 +166,7 @@ def _cache_single_object(
         else:
             refresh = True
         if refresh is True:
-            data_objects = function(**kwargs)
+            data_objects = function(**kwargs)  # type: ignore[call-arg]
             if self.cache_time > 0:
                 plain_data: str = json.dumps(data_objects, default=pydantic_encoder)
                 base64_data: bytes = base64.b64encode(plain_data.encode("utf-8"))
@@ -224,7 +224,7 @@ def get_latest_cache(
             )
             cache_attribute: Union[Dict[int, LunchableModel], LunchableModel]
             if isinstance(cache, list):
-                cache_attribute = {item.id: item for item in cache}  # type: ignore
+                cache_attribute = {item.id: item for item in cache}
             else:
                 cache_attribute = cache
             setattr(