Skip to content

Conversation

@julien-duponchelle
Copy link
Owner

This the pull request is about memory leak reported by @YvesDup in #57.

I think this need to be merge in binlogstream before merge of the pull request.

@julien-duponchelle
Copy link
Owner Author

I have backported the changes to binlogstream. For me it's ok with Python 2.7 and Python 3.3 and with MySQL 5.7.

Someone else?

Thanks a lot @YvesDup for this great patch

@bjoernhaeuser
Copy link
Collaborator

We should add some more tests to that case, right?

@YvesDup
Copy link

YvesDup commented Jan 6, 2014

In the new version of BinLogStreamReader class, the "__manage_if_last_event_of_statement" method is never call. This method has to be used to manage items of the two dictionaries, table_map and dict_table_id.

My favorite solution is to implement a "yield" in replacement of "return" in the "fetchone" method. Because after the yield you can call the "__manage_if_last_event_of_statement" method as you can see in YieldBinLogStreamReader class.
An another solution is possible but is more difficult to implement (add more self variables).

And I am wondering how to get back the last safe position of binlog as to restart without error. Any idea ?
May be is not the good place to talk about that ?

About new tests, I did not see event about "alter" order on table (in the examples of project).

@julien-duponchelle julien-duponchelle changed the title Fix memory leak Fix memory issues with large number of tables Jul 15, 2014
@julien-duponchelle
Copy link
Owner Author

Too old I 'm not going to rebase it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants