set_dot implementation #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This closes #26 |
blegat
reviewed
Jul 23, 2019
blegat
reviewed
Jul 23, 2019
| function set_dot(i::Int, s::MOI.AbstractVectorSet, T::DataType) | ||
| vec = zeros(T, MOI.dimension(s)) | ||
| vec[i] = one(T) | ||
| return MOIU.set_dot(vec, vec, s) |
There was a problem hiding this comment.
We should modify MOIU.set_dot to accept AbstractArray so that vec can be passed as a sparse vector
There was a problem hiding this comment.
I don't know if this is super simple, I can try it tomorrow
There was a problem hiding this comment.
Thanks for the PR! Add a comment to change this once jump-dev/MathOptInterface.jl#805 is merged and released.
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
- Coverage 94.56% 94.24% -0.32%
==========================================
Files 10 10
Lines 239 226 -13
==========================================
- Hits 226 213 -13
Misses 13 13
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we can query the dual coefficients for the matrix A^T using set_dot, and it is easier to extend to new cones