Skip to content

Conversation

guilhermebodin
Copy link
Contributor

This will allow users to use set_dot with sparse vectors too

@codecov-io
Copy link

codecov-io commented Jul 23, 2019

Codecov Report

Merging #805 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #805      +/-   ##
==========================================
+ Coverage   93.97%   94.11%   +0.13%     
==========================================
  Files          59       59              
  Lines        6690     6690              
==========================================
+ Hits         6287     6296       +9     
+ Misses        403      394       -9
Impacted Files Coverage Δ
src/Utilities/results.jl 86.66% <100%> (+6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 625fcc5...a9384e4. Read the comment docs.

Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add tests ?

@mlubin mlubin merged commit 2c0e0fc into jump-dev:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants