Skip to content

Conversation

ericphanson
Copy link
Contributor

BenchmarkTools made a semver-breaking release although did not really break anything (just removed Julia 0.7 support and added features).

I could make a PR to add CompatHelper support if that would be desired.

@odow
Copy link
Member

odow commented Feb 24, 2020

CompatHelper would be good. I haven't looked at it yet.

@ericphanson
Copy link
Contributor Author

CompatHelper just checks once a day if there are new releases of dependencies and opens a PR to broaden compat with each package who got a new release (but does not check that they work). Ideally, then your CI tests the PR with the new version, and if it passes, you merge.

That doesn't work perfectly though, because you need to check that the CI actually tested with the new version of the package (because it might not if some other package is holding back the dependency whose compat you just broadened; ref JuliaRegistries/CompatHelper.jl#183). Even though it's not perfect, I think it's still useful to at least know there is a new version of a dependency, and you can check the CI logs to see if it uses the new version as well.

@codecov-io
Copy link

Codecov Report

Merging #1034 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1034   +/-   ##
=======================================
  Coverage   95.19%   95.19%           
=======================================
  Files         100      100           
  Lines       11344    11344           
=======================================
  Hits        10799    10799           
  Misses        545      545

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4af130f...8150ac7. Read the comment docs.

@odow
Copy link
Member

odow commented Feb 25, 2020

Yes, at the very least, being notified of new releases seems useful.

Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for CompatHelper

@odow odow merged commit 41ded26 into jump-dev:master Feb 25, 2020
@ericphanson ericphanson deleted the patch-1 branch February 25, 2020 18:36
@ericphanson ericphanson mentioned this pull request Feb 25, 2020
@blegat blegat added this to the v0.9.13 milestone Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants