Skip to content

Conversation

odow
Copy link
Member

@odow odow commented Feb 26, 2020

Two bugs:

  1. We were still assuming NLPBlock used x[1] instead of x[VariableIndex(1)]
  2. NLP objectives were being overwritten by empty linear/quadratic ones because the JSON file for the test was wrong :(

@codecov-io
Copy link

codecov-io commented Feb 26, 2020

Codecov Report

Merging #1037 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1037      +/-   ##
==========================================
- Coverage   95.19%   95.19%   -0.01%     
==========================================
  Files         100      100              
  Lines       11344    11343       -1     
==========================================
- Hits        10799    10798       -1     
  Misses        545      545
Impacted Files Coverage Δ
src/FileFormats/MOF/nonlinear.jl 100% <100%> (ø) ⬆️
src/FileFormats/MOF/write.jl 66.31% <100%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d12a510...a808701. Read the comment docs.

@odow
Copy link
Member Author

odow commented Feb 26, 2020

Codecov is annoying again.

@blegat objections to merging this and then tagging 0.9.12?

@blegat blegat added this to the v0.9.12 milestone Feb 27, 2020
@odow odow merged commit 2d68079 into master Feb 27, 2020
@odow odow deleted the od/mof_nlp branch February 27, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants