Skip to content

Bugfix for set ConstraintFunction in ScalarizeBridge. #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 29, 2020
Merged

Bugfix for set ConstraintFunction in ScalarizeBridge. #1093

merged 2 commits into from
May 29, 2020

Conversation

martinbiel
Copy link
Contributor

I found a small bug in ScalarizeBridge. This should fix it.

@martinbiel
Copy link
Contributor Author

The bridge.constants[i] != old_constants[i] case is probably not encountered in tests as this would have triggered a runtime error.

@blegat
Copy link
Member

blegat commented May 29, 2020

Thanks! Could you add a test ?
It could be as simple as a custom test in https://github.com/JuliaOpt/MathOptInterface.jl/blob/3f872f9edb50b1a97cb65011430a0160fd56111e/test/Bridges/Constraint/scalarize.jl or even a new test in https://github.com/JuliaOpt/MathOptInterface.jl/blob/3f872f9edb50b1a97cb65011430a0160fd56111e/src/Test/UnitTests/modifications.jl that is called from https://github.com/JuliaOpt/MathOptInterface.jl/blob/3f872f9edb50b1a97cb65011430a0160fd56111e/test/Bridges/Constraint/scalarize.jl.

blegat
blegat approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@blegat blegat merged commit 0b5cd4d into jump-dev:master May 29, 2020
@martinbiel martinbiel deleted the scalarize_bugfix branch May 29, 2020 22:11
@blegat blegat added this to the v0.9.14 milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blegat blegat blegat approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

v0.9.14

Development

Successfully merging this pull request may close these issues.

2 participants

@martinbiel @blegat