Skip to content

Conversation

odow
Copy link
Member

@odow odow commented Aug 23, 2020

@odow
Copy link
Member Author

odow commented Aug 23, 2020

Any other changes we want?

@blegat
Copy link
Member

blegat commented Aug 28, 2020

What is going to happen when you try to read an old file with the new MOI ? It will print an error message saying that the version does not match ?

@odow
Copy link
Member Author

odow commented Aug 29, 2020

Ah. Good catch. This piece of code doesn't really make sense:

if file_version > VERSION
error(
"Sorry, the file can't be read because this library supports " *
"v$(VERSION) of MathOptFormat, but the file you are trying to " *
"read is v$(file_version)."
)
end

Hold off merging, and I will push a fix.

@odow odow requested a review from blegat August 31, 2020 00:14
@odow odow merged commit 753923a into master Aug 31, 2020
@odow odow deleted the od/mof5 branch August 31, 2020 21:43
@blegat blegat added this to the v0.9.15 milestone Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants