Skip to content

Implement get for CleverDict #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2020
Merged

Implement get for CleverDict #1153

merged 2 commits into from
Sep 4, 2020

Conversation

blegat
Copy link
Member

@blegat blegat commented Sep 3, 2020

OSQP is comparing a CleverDict with a Dict which requires CleverDict to implement get which is part of the AbstractDict API, see
https://travis-ci.com/github/blegat/SolverTests/jobs/380241593#L549-L565

@blegat blegat added this to the v0.9.15 milestone Sep 3, 2020
odow
odow approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially could do with a test when !_is_dense(c).

@blegat blegat merged commit aff4e0f into master Sep 4, 2020
@blegat blegat deleted the bl/clever_dict_get branch September 4, 2020 11:57
@odow
Copy link
Member

odow commented Sep 4, 2020

This didn't seem to work: https://travis-ci.com/github/blegat/SolverTests/jobs/380241593#L552

@odow
Copy link
Member

odow commented Sep 4, 2020

Oh, it needs the same thing for DoubleDict.

@blegat blegat mentioned this pull request Sep 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@odow odow odow approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

v0.9.15

Development

Successfully merging this pull request may close these issues.

2 participants

@blegat @odow