Skip to content

Fix CleverDict with negative indices #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2020
Merged

Fix CleverDict with negative indices #1168

merged 1 commit into from
Sep 19, 2020

Conversation

blegat
Copy link
Member

@blegat blegat commented Sep 19, 2020

When negative indices are set, we should set last_index to -1 so that add_item throws an error. @joaquimg
also notified me about the edge case when last_index is -1 and h is 0 where we have h == last_index + 1.

@blegat blegat added this to the v0.9.17 milestone Sep 19, 2020
@blegat blegat merged commit bc0e777 into master Sep 19, 2020
@blegat blegat deleted the bl/clever_neg_error branch September 19, 2020 22:39
@odow odow mentioned this pull request Sep 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

v0.9.17

Development

Successfully merging this pull request may close these issues.

1 participant

@blegat