Skip to content

[breaking] Rename ListOfConstraints -> ListOfConstraintTypesPresent #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2021
Merged

[breaking] Rename ListOfConstraints -> ListOfConstraintTypesPresent #1305

merged 2 commits into from
May 2, 2021

Conversation

odow
Copy link
Member

@odow odow commented Apr 30, 2021

This has always been a weirdly named attribute.

Closes #214

@odow odow added the breaking label Apr 30, 2021
@odow odow added this to the v0.10 milestone Apr 30, 2021
blegat
blegat approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's wait for other inputs about the name

@joaquimg
Copy link
Member

joaquimg commented May 1, 2021

This is already much better than before.

Why not just ListOfConstraintTypes?
Do we really need Present? We don't do NumberOfConstraintsPresent. Found no discussion on the links, sorry if I missed (double sorry if I was in the previous discussion).
If we really need, then
I like that the Present qualification is at the end, however, ListOfCurrentConstraintTypes sounded better to me.
Not sure...

@odow
Copy link
Member Author

odow commented May 1, 2021

The argument was that ListOfConstraintTypes could be interpreted as the constraint type supported by the model, not just the ones for which NumberOfConstraints > 0.

We could have ListOfPresentConstraintTypes so allow ListOfSupportedConstraintTypes in future.

@odow odow merged commit 5f170e2 into master May 2, 2021
@odow odow deleted the od/ListOfConstraintTypesPresent branch May 2, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blegat blegat blegat approved these changes

@joaquimg joaquimg joaquimg approved these changes

Assignees
No one assigned
Labels
breaking
Milestone
v0.10
Development

Successfully merging this pull request may close these issues.

rename ListOfConstraints?
3 participants
@odow @joaquimg @blegat