[breaking] Rename .variable_index fields to .variable #1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blegat
approved these changes
May 2, 2021
There was a problem hiding this comment.
I agree, I never remember for which one it is variable and which one it is variable_index.
I like the rule: no need to add this in the name if it's already in the signature. Here, the fact that it's an index is already in the type so we can just call it variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not necessarily sold on this one.
The other option is to rename
SingleVariableto.variable_indexandVectorOfVariablesto.variable_indices. Either way, we should standardize.Closes #641